Managed bookmarks for supervised users

chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 282 matching lines @@
   // Returns the index of the first hidden bookmark button. If all buttons are
   // visible, this returns GetBookmarkButtonCount().
   int GetFirstHiddenNodeIndex();
 
   // Creates the button showing the "Other Bookmarks" folder.
   views::MenuButton* CreateOtherBookmarksButton();
 
   // Creates the button showing the "Managed Bookmarks" folder.
   views::MenuButton* CreateManagedBookmarksButton();
 
+  // Creates the button showing the supervised bookmarks items.
+  views::MenuButton* CreateSupervisedBookmarksButton();
+
   // Creates the button used when not all bookmark buttons fit.
   views::MenuButton* CreateOverflowButton();
 
   // Creates the button for rendering the specified bookmark node.
   views::View* CreateBookmarkButton(const BookmarkNode* node);
 
   // Creates the button for rendering the apps page shortcut.
   views::LabelButton* CreateAppsPageShortcutButton();
 
   // Configures the button from the specified node. This sets the text,
@@ skipping 43 matching lines @@
   // Returns the view to throb when a node is removed. |parent| is the parent of
   // the node that was removed, and |old_index| the index of the node that was
   // removed.
   views::CustomButton* DetermineViewToThrobFromRemove(
       const BookmarkNode* parent,
       int old_index);
 
   // Updates the colors for all the child objects in the bookmarks bar.
   void UpdateColors();
 
-  // Updates the visibility of |other_bookmarks_button_| and
-  // |managed_bookmarks_button_|. Also shows or hides the separator if required.
+  // Updates the visibility of |other_bookmarks_button_|,
+  // |managed_bookmarks_button_|, and |supervised_bookmarks_button_|. Also
+  // shows or hides the separator if required.
   // Returns true if something changed and a LayoutAndPaint() is needed.
   bool UpdateOtherAndManagedButtonsVisibility();
 
   // Updates the visibility of |bookmarks_separator_view_|.
   void UpdateBookmarksSeparatorVisibility();
 
   // Updates the visibility of the apps shortcut based on the pref value.
   void OnAppsPageShortcutVisibilityPrefChanged();
 
   void OnShowManagedBookmarksPrefChanged();
@@ skipping 28 matching lines @@
   // If non-NULL we're showing a context menu for one of the items on the
   // bookmark bar.
   scoped_ptr<BookmarkContextMenu> context_menu_;
 
   // Shows the "Other Bookmarks" folder button.
   views::MenuButton* other_bookmarks_button_;
 
   // Shows the managed bookmarks entries.
   views::MenuButton* managed_bookmarks_button_;
 
+  // Shows the supervised bookmarks entries.
+  views::MenuButton* supervised_bookmarks_button_;

[Pam (message me for reviews), 2015/01/14 14:03:37]

It seems strange to me that the supervised bookmarks would be relegated to a
folder on the bookmarks bar. I guess that's addressed with the
bootstrapping-the-NTP ideas for the future, though.

[Marc Treib, 2015/01/14 16:40:50]

Where else would they appear? I suppose we would also show them on the special
NTP if we ever get that, but until then the bookmarks bar seems like the logical
place?

[Pam (message me for reviews), 2015/01/15 11:37:04]

I expected them to be flat on the bookmarks bar, instead of inside a folder, to
be more apparent and friendly for naive family members. Ultimately it's up to
UX, of course.

[Marc Treib, 2015/01/15 12:30:09]

FWIW, in the new bookmarks UI (which should launch Really Soon Now, at least as
an experiment), all the bookmarks do show up individually.
I think the bookmarks bar will continue to exist though, so we still might want
to change the behavior here. The current version mimics the enterprise
bookmarks. Listing the bookmarks individually would probably be a bit more work,
so I'd like to consult the UX people before actually doing that.

+
   // Shows the Apps page shortcut.
   views::LabelButton* apps_page_shortcut_;
 
   // Used to track drops on the bookmark bar view.
   scoped_ptr<DropInfo> drop_info_;
 
   // Visible if not all the bookmark buttons fit.
   views::MenuButton* overflow_button_;
 
   // Shows a text and a link to import bookmarks if there are no bookmarks in
@@ skipping 23 matching lines @@
 
   ObserverList<BookmarkBarViewObserver> observers_;
 
   // Factory used to delay showing of the drop menu.
   base::WeakPtrFactory<BookmarkBarView> show_folder_method_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkBarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_