Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 769053004: Make the execCommand() userInterface argument explicitly do nothing (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
CC:
blink-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, groby+blinkspell_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make the execCommand() userInterface argument explicitly do nothing There was no observable difference between CommandFromDOM and CommandFromDOMWithUserInterface, so keep only CommandFromDOM. A spec bug has been filed to match this: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27533 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M Source/core/dom/Document.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 9 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
philipj_slow
PTAL
6 years ago (2014-12-08 14:12:28 UTC) #2
tkent
+yosin
6 years ago (2014-12-08 23:45:55 UTC) #4
yosin_UTC9
LGTM Thanks for tidying up! (^_^)b
6 years ago (2014-12-10 01:06:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769053004/1
6 years ago (2014-12-10 08:19:19 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-10 08:22:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186834

Powered by Google App Engine
This is Rietveld 408576698