Make the execCommand() userInterface argument explicitly do nothing

Source/core/editing/EditorCommand.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 92 matching lines @@
 }
 
 static bool applyCommandToFrame(LocalFrame& frame, EditorCommandSource source, EditAction action, StylePropertySet* style)
 {
     // FIXME: We don't call shouldApplyStyle when the source is DOM; is there a good reason for that?
     switch (source) {
     case CommandFromMenuOrKeyBinding:
         frame.editor().applyStyleToSelection(style, action);
         return true;
     case CommandFromDOM:
-    case CommandFromDOMWithUserInterface:
         frame.editor().applyStyle(style);
         return true;
     }
     ASSERT_NOT_REACHED();
     return false;
 }
 
 static bool executeApplyStyle(LocalFrame& frame, EditorCommandSource source, EditAction action, CSSPropertyID propertyID, const String& propertyValue)
 {
     RefPtrWillBeRawPtr<MutableStylePropertySet> style = MutableStylePropertySet::create();
@@ skipping 54 matching lines @@
 static bool executeApplyParagraphStyle(LocalFrame& frame, EditorCommandSource source, EditAction action, CSSPropertyID propertyID, const String& propertyValue)
 {
     RefPtrWillBeRawPtr<MutableStylePropertySet> style = MutableStylePropertySet::create();
     style->setProperty(propertyID, propertyValue);
     // FIXME: We don't call shouldApplyStyle when the source is DOM; is there a good reason for that?
     switch (source) {
     case CommandFromMenuOrKeyBinding:
         frame.editor().applyParagraphStyleToSelection(style.get(), action);
         return true;
     case CommandFromDOM:
-    case CommandFromDOMWithUserInterface:
         frame.editor().applyParagraphStyle(style.get());
         return true;
     }
     ASSERT_NOT_REACHED();
     return false;
 }
 
 static bool executeInsertFragment(LocalFrame& frame, PassRefPtrWillBeRawPtr<DocumentFragment> fragment)
 {
     ASSERT(frame.document());
@@ skipping 98 matching lines @@
 }
 
 static bool executeCopy(LocalFrame& frame, Event*, EditorCommandSource, const String&)
 {
     frame.editor().copy();
     return true;
 }
 
 static bool executeCreateLink(LocalFrame& frame, Event*, EditorCommandSource, const String& value)
 {
-    // FIXME: If userInterface is true, we should display a dialog box to let the user enter a URL.
     if (value.isEmpty())
         return false;
     ASSERT(frame.document());
     CreateLinkCommand::create(*frame.document(), value)->apply();
     return true;
 }
 
 static bool executeCut(LocalFrame& frame, Event*, EditorCommandSource, const String&)
 {
     frame.editor().cut();
@@ skipping 12 matching lines @@
 
 static bool executeDelete(LocalFrame& frame, Event*, EditorCommandSource source, const String&)
 {
     switch (source) {
     case CommandFromMenuOrKeyBinding: {
         // Doesn't modify the text if the current selection isn't a range.
         frame.editor().performDelete();
         return true;
     }
     case CommandFromDOM:
-    case CommandFromDOMWithUserInterface:
         // If the current selection is a caret, delete the preceding character. IE performs forwardDelete, but we currently side with Firefox.
         // Doesn't scroll to make the selection visible, or modify the kill ring (this time, siding with IE, not Firefox).
         ASSERT(frame.document());
         TypingCommand::deleteKeyPressed(*frame.document(), frame.selection().granularity() == WordGranularity ? TypingCommand::SmartDelete : 0);
         return true;
     }
     ASSERT_NOT_REACHED();
     return false;
 }
 
@@ skipping 115 matching lines @@
     return command->didApply();
 }
 
 static bool executeForwardDelete(LocalFrame& frame, Event*, EditorCommandSource source, const String&)
 {
     switch (source) {
     case CommandFromMenuOrKeyBinding:
         frame.editor().deleteWithDirection(DirectionForward, CharacterGranularity, false, true);
         return true;
     case CommandFromDOM:
-    case CommandFromDOMWithUserInterface:
         // Doesn't scroll to make the selection visible, or modify the kill ring.
         // ForwardDelete is not implemented in IE or Firefox, so this behavior is only needed for
         // backward compatibility with ourselves, and for consistency with Delete.
         ASSERT(frame.document());
         TypingCommand::forwardDeleteKeyPressed(*frame.document());
         return true;
     }
     ASSERT_NOT_REACHED();
     return false;
 }
@@ skipping 26 matching lines @@
 }
 
 static bool executeInsertHTML(LocalFrame& frame, Event*, EditorCommandSource, const String& value)
 {
     ASSERT(frame.document());
     return executeInsertFragment(frame, createFragmentFromMarkup(*frame.document(), value, ""));
 }
 
 static bool executeInsertImage(LocalFrame& frame, Event*, EditorCommandSource, const String& value)
 {
-    // FIXME: If userInterface is true, we should display a dialog box and let the user choose a local image.
     ASSERT(frame.document());
     RefPtrWillBeRawPtr<HTMLImageElement> image = HTMLImageElement::create(*frame.document());
     image->setSrc(value);
     return executeInsertElement(frame, image.release());
 }
 
 static bool executeInsertLineBreak(LocalFrame& frame, Event* event, EditorCommandSource source, const String&)
 {
     switch (source) {
     case CommandFromMenuOrKeyBinding:
         return targetFrame(frame, event)->eventHandler().handleTextInputEvent("\n", event, TextEventInputLineBreak);
     case CommandFromDOM:
-    case CommandFromDOMWithUserInterface:
         // Doesn't scroll to make the selection visible, or modify the kill ring.
         // InsertLineBreak is not implemented in IE or Firefox, so this behavior is only needed for
         // backward compatibility with ourselves, and for consistency with other commands.
         ASSERT(frame.document());
         TypingCommand::insertLineBreak(*frame.document(), 0);
         return true;
     }
     ASSERT_NOT_REACHED();
     return false;
 }
@@ skipping 702 matching lines @@
 {
     return frame.editor().selectionForCommand(event).rootEditableElement();
 }
 
 static bool enabledDelete(LocalFrame& frame, Event* event, EditorCommandSource source)
 {
     switch (source) {
     case CommandFromMenuOrKeyBinding:
         return frame.editor().canDelete();
     case CommandFromDOM:
-    case CommandFromDOMWithUserInterface:
         // "Delete" from DOM is like delete/backspace keypress, affects selected range if non-empty,
         // otherwise removes a character
         return enabledInEditableText(frame, event, source);
     }
     ASSERT_NOT_REACHED();
     return false;
 }
 
 static bool enabledInEditableTextOrCaretBrowsing(LocalFrame& frame, Event* event, EditorCommandSource)
 {
@@ skipping 483 matching lines @@
 }
 
 bool Editor::Command::isSupported() const
 {
     if (!m_command)
         return false;
     switch (m_source) {
     case CommandFromMenuOrKeyBinding:
         return true;
     case CommandFromDOM:
-    case CommandFromDOMWithUserInterface:
         return m_command->isSupportedFromDOM(m_frame.get());
     }
     ASSERT_NOT_REACHED();
     return false;
 }
 
 bool Editor::Command::isEnabled(Event* triggeringEvent) const
 {
     if (!isSupported() || !m_frame)
         return false;
@@ skipping 20 matching lines @@
 {
     return m_command && m_command->isTextInsertion;
 }
 
 int Editor::Command::idForHistogram() const
 {
     return isSupported() ? m_command->idForUserMetrics : 0;
 }
 
 } // namespace blink