Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: net/http/proxy_client_socket.h

Issue 769043003: Sanitize headers in Proxy Authentication Required responses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix sleevi's nit Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_proxy_client_socket.cc ('k') | net/http/proxy_client_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/proxy_client_socket.h
diff --git a/net/http/proxy_client_socket.h b/net/http/proxy_client_socket.h
index aa5903811166f8016a7327dc3d6f3f7151f1e5a8..f3347c8972e14677a15b1841c5de9dd65389124b 100644
--- a/net/http/proxy_client_socket.h
+++ b/net/http/proxy_client_socket.h
@@ -74,13 +74,19 @@ class NET_EXPORT_PRIVATE ProxyClientSocket : public StreamSocket {
const GURL& url,
bool is_https_proxy);
+ // When a proxy authentication response is received during tunnel
+ // construction, this method should be called to strip everything
+ // but the auth header from the redirect response. If it returns
+ // false, the response should be discarded and tunnel construction should
+ // fail.
+ static bool SanitizeProxyAuth(HttpResponseInfo* response);
+
// When a redirect (e.g. 302 response) is received during tunnel
// construction, this method should be called to strip everything
// but the Location header from the redirect response. If it returns
// false, the response should be discarded and tunnel construction should
- // fail. |url| is for logging purposes.
- static bool SanitizeProxyRedirect(HttpResponseInfo* response,
- const GURL& url);
+ // fail.
+ static bool SanitizeProxyRedirect(HttpResponseInfo* response);
private:
DISALLOW_COPY_AND_ASSIGN(ProxyClientSocket);
« no previous file with comments | « net/http/http_proxy_client_socket.cc ('k') | net/http/proxy_client_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698