Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: net/http/proxy_client_socket.h

Issue 769043003: Sanitize headers in Proxy Authentication Required responses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix sleevi's nit Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_proxy_client_socket.cc ('k') | net/http/proxy_client_socket.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_PROXY_CLIENT_SOCKET_H_ 5 #ifndef NET_HTTP_PROXY_CLIENT_SOCKET_H_
6 #define NET_HTTP_PROXY_CLIENT_SOCKET_H_ 6 #define NET_HTTP_PROXY_CLIENT_SOCKET_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "net/socket/ssl_client_socket.h" 10 #include "net/socket/ssl_client_socket.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // construction/ this method should be called. 67 // construction/ this method should be called.
68 static int HandleProxyAuthChallenge(HttpAuthController* auth, 68 static int HandleProxyAuthChallenge(HttpAuthController* auth,
69 HttpResponseInfo* response, 69 HttpResponseInfo* response,
70 const BoundNetLog& net_log); 70 const BoundNetLog& net_log);
71 71
72 // Logs (to the log and in a histogram) a blocked CONNECT response. 72 // Logs (to the log and in a histogram) a blocked CONNECT response.
73 static void LogBlockedTunnelResponse(int http_response_code, 73 static void LogBlockedTunnelResponse(int http_response_code,
74 const GURL& url, 74 const GURL& url,
75 bool is_https_proxy); 75 bool is_https_proxy);
76 76
77 // When a proxy authentication response is received during tunnel
78 // construction, this method should be called to strip everything
79 // but the auth header from the redirect response. If it returns
80 // false, the response should be discarded and tunnel construction should
81 // fail.
82 static bool SanitizeProxyAuth(HttpResponseInfo* response);
83
77 // When a redirect (e.g. 302 response) is received during tunnel 84 // When a redirect (e.g. 302 response) is received during tunnel
78 // construction, this method should be called to strip everything 85 // construction, this method should be called to strip everything
79 // but the Location header from the redirect response. If it returns 86 // but the Location header from the redirect response. If it returns
80 // false, the response should be discarded and tunnel construction should 87 // false, the response should be discarded and tunnel construction should
81 // fail. |url| is for logging purposes. 88 // fail.
82 static bool SanitizeProxyRedirect(HttpResponseInfo* response, 89 static bool SanitizeProxyRedirect(HttpResponseInfo* response);
83 const GURL& url);
84 90
85 private: 91 private:
86 DISALLOW_COPY_AND_ASSIGN(ProxyClientSocket); 92 DISALLOW_COPY_AND_ASSIGN(ProxyClientSocket);
87 }; 93 };
88 94
89 } // namespace net 95 } // namespace net
90 96
91 #endif // NET_HTTP_PROXY_CLIENT_SOCKET_H_ 97 #endif // NET_HTTP_PROXY_CLIENT_SOCKET_H_
OLDNEW
« no previous file with comments | « net/http/http_proxy_client_socket.cc ('k') | net/http/proxy_client_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698