Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 768793002: Revert of IDL: Null values should be converted for non-nullable dictionary members (Closed)

Created:
6 years ago by pfeldman
Modified:
6 years ago
Reviewers:
haraken, Jens Widell, zino, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of IDL: Null values should be converted for non-nullable dictionary members (patchset #2 id:20001 of https://codereview.chromium.org/765673005/) Reason for revert: Build failed: http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/13713/steps/compile/logs/stdio Original issue's description: > IDL: Null values should be converted for non-nullable dictionary members > > The current implementation of the binding layer treats null values > as the same as undefined, but this behavior doesn't match what the > spec specified. According to the spec[1], when null is passed to > a dictionary member, we should do conversion unless the member is > nullable. For example, given a dictionary member and the type > of the member is DOMString, passing null should result in "null" > (of type string). This CL changes the binding's behavior to follow > the spec. > > [1] http://heycam.github.io/webidl/#es-dictionary > BUG=321462 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186169 TBR=haraken@chromium.org,jl@opera.com,jinho.bang@samsung.com,bashi@chromium.org NOTREECHECKS=true NOTRY=true BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -228 lines) Patch
M LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-hit-regions-basic-test-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html View 1 chunk +13 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test-expected.txt View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest.html View 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_dictionary.py View 5 chunks +8 lines, -18 lines 0 comments Download
M Source/bindings/templates/dictionary_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 2 chunks +9 lines, -18 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 5 chunks +0 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 2 chunks +80 lines, -154 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp View 1 chunk +8 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
Created Revert of IDL: Null values should be converted for non-nullable dictionary members
6 years ago (2014-11-28 11:45:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768793002/1
6 years ago (2014-11-28 11:46:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=186170
6 years ago (2014-11-28 11:47:10 UTC) #3
haraken
6 years ago (2014-11-28 11:47:32 UTC) #4
Message was sent while issue was closed.
LGTM, thanks for the revert!

Powered by Google App Engine
This is Rietveld 408576698