Chromium Code Reviews
DescriptionRevert of IDL: Null values should be converted for non-nullable dictionary members (patchset #2 id:20001 of https://codereview.chromium.org/765673005/)
Reason for revert:
Build failed: http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/13713/steps/compile/logs/stdio
Original issue's description:
> IDL: Null values should be converted for non-nullable dictionary members
>
> The current implementation of the binding layer treats null values
> as the same as undefined, but this behavior doesn't match what the
> spec specified. According to the spec[1], when null is passed to
> a dictionary member, we should do conversion unless the member is
> nullable. For example, given a dictionary member and the type
> of the member is DOMString, passing null should result in "null"
> (of type string). This CL changes the binding's behavior to follow
> the spec.
>
> [1] http://heycam.github.io/webidl/#es-dictionary
> BUG=321462
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186169
TBR=haraken@chromium.org,jl@opera.com,jinho.bang@samsung.com,bashi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=321462
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186170
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|