LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html - Issue 768793002: Revert of IDL: Null values should be converted for non-nullable dictionary members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

Issue 768793002: Revert of IDL: Null values should be converted for non-nullable dictionary members (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-hit-regions-basic-test-expected.txt ('k') | LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

diff --git a/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html b/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

index 591f7318610c6bad14b844a377ccbb5ae80872cf..5bdbe3cefd829c92a2ee17d099eabca1a6da0be4 100644

--- a/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

+++ b/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

@@ -77,7 +77,19 @@

context.removeHitRegion("nonzero");

- shouldThrow('context.addHitRegion({id : "nonzero", fillRule : null });');

+ context.addHitRegion({

+ id : "nonzero",

+ fillRule : null

+ });

+ debug("fillRule = null, falls back to default (nonzero):");

+ shouldBe("clickCanvas(1, 1)", "'nonzero'");

+ shouldBe("clickCanvas(99, 98)", "'nonzero'");

+ shouldBe("clickCanvas(21, 21)", "'nonzero'");

+ shouldBe("clickCanvas(50, 50)", "'nonzero'");

+ debug("");

+ context.removeHitRegion("nonzero");

context.addHitRegion({

id : "nonzero",