Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 768653002: Revert "Animations: Pass animation timing function through to compositor." (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dglazkov+blink, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Revert "Animations: Pass animation timing function through to compositor." This reverts commit 76fdebf3158ef64f73f3f882a669b30756cffc60. It breaks webkit_unit_tests on Windows debug bots, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8536 TBR=ikilpatrick@chromium.org,tkent,dstockwell,samli BUG=437183, 417909 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -200 lines) Patch
D ManualTests/animation/compositor-animation-cubic.html View 1 chunk +0 lines, -89 lines 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 6 chunks +11 lines, -40 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 3 chunks +7 lines, -62 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTestHelper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/platform/WebFilterAnimationCurve.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebFloatAnimationCurve.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/platform/WebTransformAnimationCurve.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sof
Please take a look. Windows dbg trybots also fail, reverting.
6 years ago (2014-11-27 21:10:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768653002/1
6 years ago (2014-11-27 21:11:16 UTC) #3
commit-bot: I haz the power
6 years ago (2014-11-27 21:11:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186138

Powered by Google App Engine
This is Rietveld 408576698