Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 7685041: Merge 92298 - Crash in DocumentWriter::endIfNotLoadingMainResource (Closed)

Created:
9 years, 6 months ago by kerz_chromium
Modified:
9 years, 6 months ago
Reviewers:
abarth
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 92298 - Crash in DocumentWriter::endIfNotLoadingMainResource https://bugs.webkit.org/show_bug.cgi?id=65581 Reviewed by Nate Chapin. Source/WebCore: This function is poorly designed because isLoadingMainResource is a poor proxy for determing whether to flush/finish the parser. Really, we should change how loads complete to match the model in HTML5, but that's pretty tricky. In the meantime, this null check fixes the crash. I'm sure there's another bug on file about this crash, but we've never been able to reproduce it. Thanks to Berend-Jan Wever for the test case! Test: fast/loader/reload-zero-byte-plugin.html * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::endIfNotLoadingMainResource): LayoutTests: * fast/loader/reload-zero-byte-plugin-expected.txt: Added. * fast/loader/reload-zero-byte-plugin.html: Added. TBR=abarth@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11713 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +0 lines, -2591 lines 0 comments Download
A + LayoutTests/fast/loader/reload-zero-byte-plugin.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/loader/reload-zero-byte-plugin-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +14 lines, -9124 lines 0 comments Download
M Source/WebCore/loader/DocumentWriter.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
9 years, 6 months ago (2011-08-23 01:03:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698