Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: Source/WebCore/loader/DocumentWriter.cpp

Issue 7685041: Merge 92298 - Crash in DocumentWriter::endIfNotLoadingMainResource (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/ChangeLog ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/loader/DocumentWriter.cpp
===================================================================
--- Source/WebCore/loader/DocumentWriter.cpp (revision 93568)
+++ Source/WebCore/loader/DocumentWriter.cpp (working copy)
@@ -211,6 +211,8 @@
void DocumentWriter::endIfNotLoadingMainResource()
{
+ // FIXME: This isn't really the check we should be doing. We should re-work
+ // how we end parsing to match the model in HTML5.
if (m_frame->loader()->isLoadingMainResource() || !m_frame->page() || !m_frame->document())
return;
@@ -219,6 +221,8 @@
// so we'll add a protective refcount
RefPtr<Frame> protector(m_frame);
+ if (!m_parser)
+ return;
// FIXME: m_parser->finish() should imply m_parser->flush().
m_parser->flush(this);
if (!m_parser)
« no previous file with comments | « Source/WebCore/ChangeLog ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698