Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 768313004: Deprecate the Document.charset setter (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update test expectations #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M LayoutTests/fast/dom/Document/document-charset-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/frame-loading-via-document-write-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/encoding/css-charset-default-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/encoding/external-script-charset-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
philipj_slow
update test expectations
6 years ago (2014-12-03 10:37:34 UTC) #1
philipj_slow
rebase
6 years ago (2014-12-04 08:17:35 UTC) #2
philipj_slow
rebase
6 years ago (2014-12-08 09:31:50 UTC) #3
philipj_slow
PTAL. No feedback on the blink-dev thread for a week, and none required per process.
6 years ago (2014-12-08 09:33:05 UTC) #5
Mike West
Try it out. LGTM.
6 years ago (2014-12-08 10:18:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768313004/60001
6 years ago (2014-12-08 11:31:07 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-08 11:33:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186686

Powered by Google App Engine
This is Rietveld 408576698