Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 768313004: Deprecate the Document.charset setter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 784 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 795
796 case FontFaceSetReady: 796 case FontFaceSetReady:
797 return "document.fonts.ready() method is going to be replaced with docum ent.fonts.ready attribute in future releases. Please be prepared. For more help, check https://code.google.com/p/chromium/issues/detail?id=392077#c3 ."; 797 return "document.fonts.ready() method is going to be replaced with docum ent.fonts.ready attribute in future releases. Please be prepared. For more help, check https://code.google.com/p/chromium/issues/detail?id=392077#c3 .";
798 798
799 case DOMImplementationHasFeatureReturnFalse: 799 case DOMImplementationHasFeatureReturnFalse:
800 return "'DOMImplementation.hasFeature()' returning false is deprecated. Please do not use it, as per DOM it should always return true (https://dom.spec. whatwg.org/#dom-domimplementation-hasfeature)."; 800 return "'DOMImplementation.hasFeature()' returning false is deprecated. Please do not use it, as per DOM it should always return true (https://dom.spec. whatwg.org/#dom-domimplementation-hasfeature).";
801 801
802 case GetMatchedCSSRules: 802 case GetMatchedCSSRules:
803 return "'getMatchedCSSRules()' is deprecated. For more help, check https ://code.google.com/p/chromium/issues/detail?id=437569#c2"; 803 return "'getMatchedCSSRules()' is deprecated. For more help, check https ://code.google.com/p/chromium/issues/detail?id=437569#c2";
804 804
805 case DocumentSetCharset:
806 return "Setting 'Document.charset' is deprecated. Please use '<meta char set=\"UTF-8\">' instead.";
807
805 // Features that aren't deprecated don't have a deprecation message. 808 // Features that aren't deprecated don't have a deprecation message.
806 default: 809 default:
807 return String(); 810 return String();
808 } 811 }
809 } 812 }
810 813
811 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 814 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
812 { 815 {
813 ASSERT(feature >= firstCSSProperty); 816 ASSERT(feature >= firstCSSProperty);
814 ASSERT(feature <= lastCSSProperty); 817 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
843 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 846 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
844 { 847 {
845 // FIXME: We may want to handle stylesheets that have multiple owners 848 // FIXME: We may want to handle stylesheets that have multiple owners
846 // http://crbug.com/242125 849 // http://crbug.com/242125
847 if (sheetContents && sheetContents->hasSingleOwnerNode()) 850 if (sheetContents && sheetContents->hasSingleOwnerNode())
848 return getFrom(sheetContents->singleOwnerDocument()); 851 return getFrom(sheetContents->singleOwnerDocument());
849 return 0; 852 return 0;
850 } 853 }
851 854
852 } // namespace blink 855 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698