convert another DCHECK into a STATIC_ASSERT

convert another DCHECK into a STATIC_ASSERT

[Mostyn Bramley-Moore, 2014-12-09 01:08:00]

mostynb@opera.com changed reviewers:
+ mvstanton@chromium.org

[Mostyn Bramley-Moore, 2014-12-09 01:08:00]

@mvstanton: here's another DCHECK that can be replaced by a STATIC_ASSERT,
please take a look.

[Jakob Kummerow, 2014-12-09 15:09:07]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2014-12-09 15:09:07]

DBC: if you're gonna do this, do it everywhere. I'm sure we have dozens of
DCHECKs that could be turned into STATIC_ASSERTs; sending dozens of one-line CLs
seems like a lot of churn for little gain (a sufficiently clever compiler would
optimize them away anyway... haven't checked if clang does it, though).

[Mostyn Bramley-Moore, 2014-12-09 15:17:09]

On 2014/12/09 15:09:07, Jakob wrote:
> DBC: if you're gonna do this, do it everywhere. I'm sure we have dozens of
> DCHECKs that could be turned into STATIC_ASSERTs; sending dozens of one-line
CLs
> seems like a lot of churn for little gain (a sufficiently clever compiler
would
> optimize them away anyway... haven't checked if clang does it, though).

Sure, I will merge this into https://codereview.chromium.org/768113007 and wait
until I can get v8 to build completely with gn+ccache+icecc+clang before asking
for someone to land the CL.

[mvstanton, 2014-12-10 08:16:38]

Okay, fair enough, I'll look at your larger CL when that is ready if you like.
Thx for the effort!