Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Issue 768113004: Constify CreatePictureShader's picture arg. (Closed)

Created:
6 years ago by f(malita)
Modified:
6 years ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : also remove FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M include/core/SkShader.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
f(malita)
6 years ago (2014-12-08 15:55:51 UTC) #1
robertphillips
lgtm
6 years ago (2014-12-08 16:00:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768113004/1
6 years ago (2014-12-08 16:01:15 UTC) #4
commit-bot: I haz the power
Presubmit check for 768113004-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-08 16:01:19 UTC) #6
reed1
lgtm
6 years ago (2014-12-08 16:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768113004/20001
6 years ago (2014-12-08 16:54:51 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-08 17:04:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2be0fd8dcbd1155ba4b702f1a606f3a816759dbb

Powered by Google App Engine
This is Rietveld 408576698