pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart - Issue 767643002: dart2js: Make usage of names more consistent between compiler and runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 767643002: dart2js: Make usage of names more consistent between compiler and runtime. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/runtime_types.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

index 143b0d40ca9ace69f381d5c0dff0bbce2e0efa5a..7ce762989fcde807e629b3178dcad2cf617f40e0 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

@@ -379,6 +379,7 @@ class OldEmitter implements Emitter {

generateEmbeddedGlobalAccess(embeddedNames.ALL_CLASSES);

jsAst.Expression metadataAccess =

generateEmbeddedGlobalAccess(embeddedNames.METADATA);

+ String signaturePropertyName = namer.operatorSignature;

return js('''

function(collectedClasses, isolateProperties, existingIsolateProperties) {

@@ -426,7 +427,7 @@ class OldEmitter implements Emitter {

supr = split[0];

var functionSignature = split[1];

if (functionSignature)

- desc.\$signature = (function(s) {

+ desc.$signaturePropertyName = (function(s) {

return function(){ return #metadata[s]; };

})(functionSignature);

}