components/autofill/content/common/autofill_messages.h - Issue 767353002: Support for password manager suggestions on password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 767353002: Support for password manager suggestions on password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Rebase on ToT Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/password_manager/core/browser/password_autofill_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 916d99b5d5d938313c5a87ab0c958035271884e8..0289fa30c0f74630d6b5328e31d4a9643577cca8 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -10,6 +10,7 @@

#include "base/strings/string16.h"

#include "base/time/time.h"

#include "components/autofill/content/common/autofill_param_traits_macros.h"

+#include "components/autofill/core/common/autofill_constants.h"

Garrett Casto 2014/12/05 19:30:54 Shouldn't need to include this here.

jww 2014/12/05 20:23:10 Done.

#include "components/autofill/core/common/form_data.h"

#include "components/autofill/core/common/form_data_predictions.h"

#include "components/autofill/core/common/form_field_data.h"

@@ -298,12 +299,13 @@ IPC_MESSAGE_ROUTED0(AutofillHostMsg_HidePasswordGenerationPopup)

// Instruct the browser to show a popup with suggestions filled from data

// associated with |key|. The popup will use |text_direction| for displaying

// text.

-IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordSuggestions,

- int /* key */,

- base::i18n::TextDirection /*text_direction */,

- base::string16 /* username typed by user */,

- bool /* show all suggestions */,

- gfx::RectF /* input field bounds, window-relative */)

+IPC_MESSAGE_ROUTED5(

+ AutofillHostMsg_ShowPasswordSuggestions,

+ int /* key */,

+ base::i18n::TextDirection /* text_direction */,

+ base::string16 /* username typed by user */,

+ int /* options bitmask of autofill::ShowPasswordSuggestionsOptions */,

+ gfx::RectF /* input field bounds, window-relative */)

// Inform browser of data list values for the curent field.

IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,