chrome/renderer/autofill/password_autofill_agent_browsertest.cc - Issue 767353002: Support for password manager suggestions on password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Issue 767353002: Support for password manager suggestions on password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Rebase on ToT Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('k') | components/autofill/content/common/autofill_messages.h » ('j') | components/autofill/content/common/autofill_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

diff --git a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

index 36e0496ef05e4ac048bd74d3734bc7453b53a02e..8e18e077d3cc3387eaf52c52d5d6175a5e94732e 100644

--- a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

+++ b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

@@ -410,12 +410,13 @@ class PasswordAutofillAgentTest : public ChromeRenderViewTest {

render_thread_->sink().GetFirstMessageMatching(

AutofillHostMsg_ShowPasswordSuggestions::ID);

EXPECT_TRUE(message);

- Tuple5<int, base::i18n::TextDirection, base::string16, bool, gfx::RectF>

+ Tuple5<int, base::i18n::TextDirection, base::string16, int, gfx::RectF>

args;

AutofillHostMsg_ShowPasswordSuggestions::Read(message, &args);

EXPECT_EQ(kPasswordFillFormDataId, args.a);

EXPECT_EQ(ASCIIToUTF16(username), args.c);

- EXPECT_EQ(show_all, args.d);

+ int options = args.d;

+ EXPECT_EQ(show_all, options & ShowPasswordSuggestionsOptions::SHOW_ALL);

render_thread_->sink().ClearMessages();

}