components/password_manager/core/browser/password_autofill_manager.h - Issue 767353002: Support for password manager suggestions on password fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.h

Issue 767353002: Support for password manager suggestions on password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Added message value to iOS grit whitelist Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/BUILD.gn ('k') | components/password_manager/core/browser/password_autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.h

diff --git a/components/password_manager/core/browser/password_autofill_manager.h b/components/password_manager/core/browser/password_autofill_manager.h

index 4da59ef9836d45a193449ed9f996378c6de9d812..1a9283098e1c96f8c57a53a7cef179c0140506c1 100644

--- a/components/password_manager/core/browser/password_autofill_manager.h

+++ b/components/password_manager/core/browser/password_autofill_manager.h

@@ -46,11 +46,12 @@ class PasswordAutofillManager : public autofill::AutofillPopupDelegate {

const autofill::PasswordFormFillData& fill_data);

// Handles a request from the renderer to show a popup with the given

- // |suggestions| from the password manager.

+ // |suggestions| from the password manager. |options| should be a bitwise mask

+ // of autofill::ShowPasswordSuggestionsOptions values.

void OnShowPasswordSuggestions(int key,

base::i18n::TextDirection text_direction,

const base::string16& typed_username,

- bool show_all,

+ int options,

const gfx::RectF& bounds);

// Invoked to clear any page specific cached values.