Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 767353002: Support for password manager suggestions on password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Added message value to iOS grit whitelist Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_autofill_manager.cc
diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc
index 87524328ce40f5c083019089da8253ca602c218b..f4cbc235df7e2984edc017e2d128b533738f2458 100644
--- a/components/password_manager/core/browser/password_autofill_manager.cc
+++ b/components/password_manager/core/browser/password_autofill_manager.cc
@@ -12,9 +12,12 @@
#include "base/strings/utf_string_conversions.h"
#include "components/autofill/core/browser/autofill_driver.h"
#include "components/autofill/core/browser/popup_item_ids.h"
+#include "components/autofill/core/common/autofill_constants.h"
#include "components/autofill/core/common/autofill_data_validation.h"
#include "components/password_manager/core/browser/password_manager_client.h"
#include "components/password_manager/core/browser/password_manager_driver.h"
+#include "components/strings/grit/components_strings.h"
+#include "ui/base/l10n/l10n_util.h"
namespace password_manager {
@@ -108,7 +111,7 @@ void PasswordAutofillManager::OnShowPasswordSuggestions(
int key,
base::i18n::TextDirection text_direction,
const base::string16& typed_username,
- bool show_all,
+ int options,
const gfx::RectF& bounds) {
std::vector<base::string16> suggestions;
std::vector<base::string16> realms;
@@ -120,7 +123,7 @@ void PasswordAutofillManager::OnShowPasswordSuggestions(
return;
}
GetSuggestions(fill_data_it->second, typed_username, &suggestions, &realms,
- show_all);
+ options & autofill::SHOW_ALL);
DCHECK_EQ(suggestions.size(), realms.size());
form_data_key_ = key;
@@ -133,6 +136,14 @@ void PasswordAutofillManager::OnShowPasswordSuggestions(
std::vector<base::string16> empty(suggestions.size());
std::vector<int> password_ids(suggestions.size(),
autofill::POPUP_ITEM_ID_PASSWORD_ENTRY);
+ if (options & autofill::IS_PASSWORD_FIELD) {
+ base::string16 password_field_suggestions_title = l10n_util::GetStringUTF16(
+ IDS_AUTOFILL_PASSWORD_FIELD_SUGGESTIONS_TITLE);
+ suggestions.insert(suggestions.begin(), password_field_suggestions_title);
+ realms.insert(realms.begin(), base::string16());
+ empty.insert(empty.begin(), base::string16());
+ password_ids.insert(password_ids.begin(), autofill::POPUP_ITEM_ID_TITLE);
+ }
autofill_client_->ShowAutofillPopup(bounds,
text_direction,
suggestions,

Powered by Google App Engine
This is Rietveld 408576698