Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 767313003: IDL dictionary: Throw a TypeError when an interface member conversion fails (Closed)

Created:
6 years ago by bashi
Modified:
6 years ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL dictionary: Throw a TypeError when an interface member conversion fails The spec says that a type error should be thrown when a dictionary member conversion for interface types fails[1]. We don't throw a type error for null (even when the member is not nullable) because in our implementation side, both null and undefined are treated as "not specified". [1] http://heycam.github.io/webidl/#es-interface BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186747

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M LayoutTests/fast/canvas/canvas-hit-regions-basic-test-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest.html View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/scripts/v8_dictionary.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 8 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
PTAL?
6 years ago (2014-12-08 23:42:38 UTC) #2
haraken
LGTM
6 years ago (2014-12-08 23:47:53 UTC) #3
bashi
On 2014/12/08 23:47:53, haraken wrote: > LGTM Thanks!
6 years ago (2014-12-08 23:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767313003/20001
6 years ago (2014-12-08 23:50:13 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-09 01:22:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186747

Powered by Google App Engine
This is Rietveld 408576698