Source/bindings/scripts/v8_dictionary.py - Issue 767313003: IDL dictionary: Throw a TypeError when an interface member conversion fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_dictionary.py

Issue 767313003: IDL dictionary: Throw a TypeError when an interface member conversion fails (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_dictionary.py

diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py

index 079a317c610a55167ef70511f68711b8a0d92850..72ad3a7fcb48612fdb1101a05c6a3cc6a7b9ce20 100644

--- a/Source/bindings/scripts/v8_dictionary.py

+++ b/Source/bindings/scripts/v8_dictionary.py

@@ -102,6 +102,8 @@ def member_context(member):

extended_attributes=member.extended_attributes),

'enum_validation_expression': unwrapped_idl_type.enum_validation_expression,

'has_method_name': has_method_name_for_dictionary_member(member),

+ 'idl_type': idl_type.base_type,

+ 'is_interface_type': idl_type.is_interface_type and not idl_type.is_dictionary,

'is_nullable': idl_type.is_nullable,

'is_object': unwrapped_idl_type.name == 'Object',

'name': member.name,

« no previous file with comments | « LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt ('k') | Source/bindings/templates/dictionary_v8.cpp » ('j') | no next file with comments »