Source/core/rendering/RenderInline.h - Issue 767283005: Take continuation into consideration when calculating absoluteClippedOverflowRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderInline.h

Issue 767283005: Take continuation into consideration when calculating absoluteClippedOverflowRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address reviewers' comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/spatial-navigation/snav-div-in-anchor-expected.txt ('k') | Source/core/rendering/RenderInline.cpp » ('j') | Source/core/rendering/RenderInline.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderInline.h

diff --git a/Source/core/rendering/RenderInline.h b/Source/core/rendering/RenderInline.h

index 3d6ee3db26bdf1be3b284dd48596e7ce71a33fd0..743f8f9d08f85aecdf21ddc5544789ee9294e083 100644

--- a/Source/core/rendering/RenderInline.h

+++ b/Source/core/rendering/RenderInline.h

@@ -97,6 +97,7 @@ public:

virtual LayoutRect localCaretRect(InlineBox*, int, LayoutUnit* extraWidthToEndOfLine) override final;

bool hitTestCulledInline(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset);

+ virtual LayoutRect absoluteClippedOverflowRect() const override final;

leviw_travelin_and_unemployed 2015/01/20 20:19:24 Nit: You only need final here. That implies overri

c.shu 2015/01/20 23:10:22 I don't have to change this line now after rebasel

protected:

virtual void willBeDestroyed() override;