Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: Source/core/rendering/RenderInline.h

Issue 767283005: Take continuation into consideration when calculating absoluteClippedOverflowRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address reviewers' comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 using RenderBoxModelObject::continuation; 90 using RenderBoxModelObject::continuation;
91 using RenderBoxModelObject::setContinuation; 91 using RenderBoxModelObject::setContinuation;
92 92
93 bool alwaysCreateLineBoxes() const { return alwaysCreateLineBoxesForRenderIn line(); } 93 bool alwaysCreateLineBoxes() const { return alwaysCreateLineBoxesForRenderIn line(); }
94 void setAlwaysCreateLineBoxes(bool alwaysCreateLineBoxes = true) { setAlways CreateLineBoxesForRenderInline(alwaysCreateLineBoxes); } 94 void setAlwaysCreateLineBoxes(bool alwaysCreateLineBoxes = true) { setAlways CreateLineBoxesForRenderInline(alwaysCreateLineBoxes); }
95 void updateAlwaysCreateLineBoxes(bool fullLayout); 95 void updateAlwaysCreateLineBoxes(bool fullLayout);
96 96
97 virtual LayoutRect localCaretRect(InlineBox*, int, LayoutUnit* extraWidthToE ndOfLine) override final; 97 virtual LayoutRect localCaretRect(InlineBox*, int, LayoutUnit* extraWidthToE ndOfLine) override final;
98 98
99 bool hitTestCulledInline(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset); 99 bool hitTestCulledInline(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset);
100 virtual LayoutRect absoluteClippedOverflowRect() const override final;
leviw_travelin_and_unemployed 2015/01/20 20:19:24 Nit: You only need final here. That implies overri
c.shu 2015/01/20 23:10:22 I don't have to change this line now after rebasel
100 101
101 protected: 102 protected:
102 virtual void willBeDestroyed() override; 103 virtual void willBeDestroyed() override;
103 104
104 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride; 105 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride;
105 106
106 virtual void computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layout Point& layerOffset) const override; 107 virtual void computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layout Point& layerOffset) const override;
107 108
108 private: 109 private:
109 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); } 110 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); }
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 183
183 RenderObjectChildList m_children; 184 RenderObjectChildList m_children;
184 RenderLineBoxList m_lineBoxes; // All of the line boxes created for this i nline flow. For example, <i>Hello<br>world.</i> will have two <i> line boxes. 185 RenderLineBoxList m_lineBoxes; // All of the line boxes created for this i nline flow. For example, <i>Hello<br>world.</i> will have two <i> line boxes.
185 }; 186 };
186 187
187 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderInline, isRenderInline()); 188 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderInline, isRenderInline());
188 189
189 } // namespace blink 190 } // namespace blink
190 191
191 #endif // RenderInline_h 192 #endif // RenderInline_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698