Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 766693002: Get rid of getCTM/setCTM pair in Font::paintGlyphsVertical (Closed)

Created:
6 years ago by fs
Modified:
6 years ago
Reviewers:
f(malita), jbroman
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Get rid of getCTM/setCTM pair in Font::paintGlyphsVertical Add a helper object GraphicsContextCTMSaver that allows local save/restore of the GC CTM in a way that is less sensitive to active recordings (and nesting of the same.)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M Source/platform/fonts/Font.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/graphics/GraphicsContextStateSaver.h View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
fs
Mutually exclusive(?) with https://codereview.chromium.org/748863004/
6 years ago (2014-11-27 10:03:52 UTC) #2
f(malita)
6 years ago (2014-12-01 22:31:14 UTC) #3 
On 2014/11/27 10:03:52, fs wrote:
> Mutually exclusive(?) with https://codereview.chromium.org/748863004/

I prefer using the existing state saver class, since there's nothing special
about paintGlyphsVertical's matrix munging. I'm also fine with adding this CTM
specialization if needed for other use cases.

Powered by Google App Engine
This is Rietveld 408576698