Populate scope sections with variable name/values

Populate scope sections with variable name/values

Now when debugger is paused scope sections are properly populated with corresponding name:value pairs for all variables.

Eventually InjectedScript may become something like a regular Sky module but at the moment I don't see how to do this gracefully given that it is parametrised by InjectedScriptHost binding. So at the moment I just store it in "injectedScript" property on the global object,

BUG=435243
R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1d0f65a8db9b6b39a110fa949646e76bdccb00c9

[yurys, 2014-11-27 17:02:21]

yurys@chromium.org changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org

[abarth-chromium, 2014-11-27 17:16:35]

> parametrised by InjectedScriptHost binding

We'll eventually add a mechanism for internal modules to import private APIs
like this.

[abarth-chromium, 2014-11-27 17:16:55]

lgtm

[abarth-chromium, 2014-11-27 17:17:34]

https://codereview.chromium.org/766683005/diff/20001/sky/engine/core/inspecto...
File sky/engine/core/inspector/InjectedScriptManager.cpp (right):

https://codereview.chromium.org/766683005/diff/20001/sky/engine/core/inspecto...
sky/engine/core/inspector/InjectedScriptManager.cpp:168: // FIXME(sky):
InjecedScript should be available as a regular module rather that using a global
variable.
I'd just use a TODO(yurys) here.  FIXME(sky) is to remind us to delete code.  :)

[yurys, 2014-11-27 17:57:04]

https://codereview.chromium.org/766683005/diff/20001/sky/engine/core/inspecto...
File sky/engine/core/inspector/InjectedScriptManager.cpp (right):

https://codereview.chromium.org/766683005/diff/20001/sky/engine/core/inspecto...
sky/engine/core/inspector/InjectedScriptManager.cpp:168: // FIXME(sky):
InjecedScript should be available as a regular module rather that using a global
variable.
On 2014/11/27 17:17:34, abarth wrote:
> I'd just use a TODO(yurys) here.  FIXME(sky) is to remind us to delete code. 
:)

Done.

[yurys, 2014-11-27 18:00:24]

Committed patchset #2 (id:20001) manually as
1d0f65a8db9b6b39a110fa949646e76bdccb00c9 (presubmit successful).