Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: sky/framework/inspector/inspector.sky

Issue 766683005: Populate scope sections with variable name/values (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Removed unused code Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <import src="/mojo/public/sky/connection.sky" as="connection" /> 1 <import src="/mojo/public/sky/connection.sky" as="connection" />
2 <import src="/mojo/public/sky/core.sky" as="core" /> 2 <import src="/mojo/public/sky/core.sky" as="core" />
3 <import src="/mojo/public/sky/support.sky" as="support" /> 3 <import src="/mojo/public/sky/support.sky" as="support" />
4 <import src="/sky/services/inspector/inspector.mojom.sky" as="inspector" /> 4 <import src="/sky/services/inspector/inspector.mojom.sky" as="inspector" />
5 <import src="console-agent.sky" as="ConsoleAgent" /> 5 <import src="console-agent.sky" as="ConsoleAgent" />
6 <import src="dom-agent.sky" as="DOMAgent" /> 6 <import src="dom-agent.sky" as="DOMAgent" />
7 <import src="page-agent.sky" as="PageAgent" /> 7 <import src="page-agent.sky" as="PageAgent" />
8 <import src="worker-agent.sky" as="WorkerAgent" /> 8 <import src="worker-agent.sky" as="WorkerAgent" />
9 <import src="runtime-agent.sky" as="RuntimeAgent" /> 9 <import src="runtime-agent.sky" as="RuntimeAgent" />
10 <import src="indexeddb-agent.sky" as="IndexedDBAgent" /> 10 <import src="indexeddb-agent.sky" as="IndexedDBAgent" />
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 } 75 }
76 }; 76 };
77 77
78 InspectorBackend.prototype.onMessage = function(data) { 78 InspectorBackend.prototype.onMessage = function(data) {
79 var message = JSON.parse(data); 79 var message = JSON.parse(data);
80 var result = this.dispatch_(message.method, message.params, message.id); 80 var result = this.dispatch_(message.method, message.params, message.id);
81 if (result === this.IMPLEMENTED_IN_CPP) 81 if (result === this.IMPLEMENTED_IN_CPP)
82 return; 82 return;
83 this.unansweredMessages_.push(message.id); 83 this.unansweredMessages_.push(message.id);
84 // FIXME: This magic return value is kinda hacky. 84 // FIXME: This magic return value is kinda hacky.
85 if (result != this.ASYNC_RESPONSE) 85 if (result !== this.ASYNC_RESPONSE)
86 this.sendResponse(message.id, result); 86 this.sendResponse(message.id, result);
87 else { 87 else {
88 window.setTimeout(function() { 88 window.setTimeout(function() {
89 if (this.unansweredMessages_.indexOf(message.id) == -1) 89 if (this.unansweredMessages_.indexOf(message.id) == -1)
90 return; 90 return;
91 console.log("Error, failed to reply to message id " + message.id); 91 console.log("Error, failed to reply to message id " + message.id);
92 }.bind(this), this.MESSAGE_TIMEOUT_MS); 92 }.bind(this), this.MESSAGE_TIMEOUT_MS);
93 } 93 }
94 }; 94 };
95 95
(...skipping 21 matching lines...) Expand all
117 117
118 var frontendHandle = internals.connectToService( 118 var frontendHandle = internals.connectToService(
119 "mojo:sky_inspector_server", inspector.InspectorFrontend.name); 119 "mojo:sky_inspector_server", inspector.InspectorFrontend.name);
120 window.frontendConnection = new connection.Connection( 120 window.frontendConnection = new connection.Connection(
121 frontendHandle, 121 frontendHandle,
122 InspectorBackend, 122 InspectorBackend,
123 inspector.InspectorFrontend.proxyClass); 123 inspector.InspectorFrontend.proxyClass);
124 124
125 window.frontend = frontendConnection.remote; 125 window.frontend = frontendConnection.remote;
126 </script> 126 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698