Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 7664004: Merge 92908 - Readback composited webgl results for printing (Closed)

Created:
9 years, 4 months ago by jamesr
Modified:
9 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

Merge 92908 - Readback composited webgl results for printing https://bugs.webkit.org/show_bug.cgi?id=65658 BUG=55927 Patch by John Bauman <jbauman@chromium.org>; on 2011-08-11 Reviewed by James Robinson. Source/WebCore: The real composited results may be locked inside the compositor context's version of a texture because the drawing buffer was automatically cleared, so read from there to get the actual presented version to draw. * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas): * platform/graphics/GraphicsContext3D.h: * platform/graphics/chromium/Extensions3DChromium.h: * platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas): * platform/graphics/chromium/WebGLLayerChromium.h: * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::paintCompositedResultsToCanvas): Source/WebKit/chromium: Add support for reading from the composited version of a canvas. * public/WebGraphicsContext3D.h: * src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::paintFramebufferToCanvas): * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paintFramebufferToCanvas): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::paintCompositedResultsToCanvas): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData): (WebCore::GraphicsContext3DInternal::reshape): * src/GraphicsContext3DInternal.h: TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1507 lines, -68 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +431 lines, -12 lines 0 comments Download
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/GraphicsContext3D.h View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +993 lines, -15 lines 0 comments Download
M Source/WebKit/chromium/public/WebGraphicsContext3D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/Extensions3DChromium.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp View 9 chunks +33 lines, -34 lines 0 comments Download
M Source/WebKit/chromium/src/GraphicsContext3DInternal.h View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
9 years, 4 months ago (2011-08-16 00:42:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698