Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 766333002: add gm to test rounding between clips and drawBitmapRect (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add gm to test rounding between clips and drawBitmapRect BUG=skia:3179 Committed: https://skia.googlesource.com/skia/+/f786901ff03f78c86962a2a1ed227f1533d16d2b

Patch Set 1 #

Patch Set 2 : drawRect may be simpler to understand, and shows the same bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M gm/bitmaprect.cpp View 1 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
reed1
6 years ago (2014-12-01 21:26:10 UTC) #2
f(malita)
LGTM. Do we need to suppress this GM temporarily?
6 years ago (2014-12-01 21:28:02 UTC) #4
reed1
On 2014/12/01 21:28:02, Florin Malita wrote: > LGTM. > > Do we need to suppress ...
6 years ago (2014-12-01 21:29:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766333002/20001
6 years ago (2014-12-01 21:43:39 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-01 21:54:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f786901ff03f78c86962a2a1ed227f1533d16d2b

Powered by Google App Engine
This is Rietveld 408576698