editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java - Issue 766323002: Compressed/optimized navigation notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java

Issue 766323002: Compressed/optimized navigation notification. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updates for review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java ('k') | editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java

diff --git a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java

index 7d61df649410ad0390c54b1f99735ecebc16bd62..8a947604dfa1c0b8ede9738d05f3e09081605b68 100644

--- a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java

+++ b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java

@@ -22,9 +22,9 @@ import com.google.dart.server.AnalysisServerListener;

import com.google.dart.server.generated.types.AnalysisError;

import com.google.dart.server.generated.types.AnalysisStatus;

import com.google.dart.server.generated.types.CompletionSuggestion;

-import com.google.dart.server.generated.types.Element;

import com.google.dart.server.generated.types.HighlightRegion;

import com.google.dart.server.generated.types.NavigationRegion;

+import com.google.dart.server.generated.types.NavigationTarget;

import com.google.dart.server.generated.types.Occurrences;

import com.google.dart.server.generated.types.Outline;

import com.google.dart.server.generated.types.OverrideMember;

@@ -195,14 +195,14 @@ public class TestAnalysisServerListener implements AnalysisServerListener {

}

/**

- * Returns a navigation {@link Element} at the given position.

+ * Returns a navigation {@link NavigationTarget} at the given position.

- public synchronized Element findNavigationElement(String file, int offset) {

+ public synchronized NavigationTarget findNavigationElement(String file, int offset) {

List<NavigationRegion> regions = getNavigationRegions(file);

if (regions != null) {

for (NavigationRegion navigationRegion : regions) {

if (navigationRegion.containsInclusive(offset)) {

- return navigationRegion.getTargets().get(0);

+ return navigationRegion.getTargetObjects().get(0);

}