editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java - Issue 766323002: Compressed/optimized navigation notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java

Issue 766323002: Compressed/optimized navigation notification. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updates for review comments. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/NavigationTarget.java ('k') | editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/TestAnalysisServerListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java

diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java

index 2c8ebb26d18d74243d5cceb6c203ddc75afc8489..006ee51950ab0ff2b612a6bbe41c785623552637 100644

--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java

+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisNavigationProcessor.java

@@ -15,6 +15,8 @@ package com.google.dart.server.internal.remote.processor;

import com.google.dart.server.AnalysisServerListener;

import com.google.dart.server.generated.types.NavigationRegion;

+import com.google.dart.server.generated.types.NavigationTarget;

+import com.google.gson.JsonArray;

import com.google.gson.JsonObject;

import java.util.List;

@@ -36,7 +38,18 @@ public class NotificationAnalysisNavigationProcessor extends NotificationProcess

public void process(JsonObject response) throws Exception {

JsonObject paramsObject = response.get("params").getAsJsonObject();

String file = paramsObject.get("file").getAsString();

- List<NavigationRegion> regions = NavigationRegion.fromJsonArray(paramsObject.get("regions").getAsJsonArray());

+ // prepare targets

+ String[] targetFiles = constructStringArray(paramsObject.get("files").getAsJsonArray());

+ List<NavigationTarget> targets = NavigationTarget.fromJsonArray(paramsObject.get("targets").getAsJsonArray());

+ for (NavigationTarget target : targets) {

+ target.lookupFile(targetFiles);

+ }

+ // prepare regions

+ JsonArray z = paramsObject.get("regions").getAsJsonArray();

+ List<NavigationRegion> regions = NavigationRegion.fromJsonArray(z);

+ for (NavigationRegion region : regions) {

+ region.lookupTargets(targets);

+ }

// notify listener

getListener().computedNavigation(file, regions);

}