Blocks should be aligned by style of parents

Source/core/rendering/RenderBox.cpp

Index: Source/core/rendering/RenderBox.cpp
diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp
index d08b3e586e7a1029c8b6f54e29794111935075af..01a21c43a10be798c0924b8e8066a2e9ce6cf3a2 100644
--- a/Source/core/rendering/RenderBox.cpp
+++ b/Source/core/rendering/RenderBox.cpp
@@ -1886,8 +1886,11 @@ void RenderBox::computeLogicalWidth(LogicalExtentComputedValues& computedValues)
     }
 
     // Margin calculations.
-    computeMarginsForDirection(InlineDirection, cb, containerLogicalWidth, computedValues.m_extent, computedValues.m_margins.m_start,
-        computedValues.m_margins.m_end, style()->marginStart(), style()->marginEnd());
+    bool hasInvertedDirection = cb->style()->isLeftToRightDirection() == style()->isLeftToRightDirection();

[mstensho (USE GERRIT), 2014/12/04 12:18:29]

This name seems inverted. :) It's true when the direction is the same in both
renderers.

Also, we should have a test for LTR inside RTL.

But, more importantly: There are other calls to computeMarginsForDirection(),
and you haven't added any margin flipping there. Seems inconsistent. Maybe
computeMarginsForDirection() is the place to do this? That's where we make sure
to honor the align="right" thing anyway. So I think that doing it correctly
there would be the best fix.

[Kyungtae Kim, 2014/12/08 07:00:13]

Done.

+    computeMarginsForDirection(InlineDirection, cb, containerLogicalWidth, computedValues.m_extent,
+        hasInvertedDirection ? computedValues.m_margins.m_start :  computedValues.m_margins.m_end,

[mstensho (USE GERRIT), 2014/12/04 12:18:29]

extraneous space

[Kyungtae Kim, 2014/12/08 07:00:13]

Done.

+        hasInvertedDirection ? computedValues.m_margins.m_end : computedValues.m_margins.m_start,
+        style()->marginStart(), style()->marginEnd());
 
     if (!hasPerpendicularContainingBlock && containerLogicalWidth && containerLogicalWidth != (computedValues.m_extent + computedValues.m_margins.m_start + computedValues.m_margins.m_end)
         && !isFloating() && !isInline() && !cb->isFlexibleBoxIncludingDeprecated() && !cb->isRenderGrid()) {