Blocks should be aligned by style of parents

Source/core/rendering/RenderBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 1868 matching lines @@
         computedValues.m_extent = logicalWidthLength.value() + borderAndPaddingLogicalWidth();
     else {
         LayoutUnit containerWidthInInlineDirection = containerLogicalWidth;
         if (hasPerpendicularContainingBlock)
             containerWidthInInlineDirection = perpendicularContainingBlockLogicalHeight();
         LayoutUnit preferredWidth = computeLogicalWidthUsing(MainOrPreferredSize, styleToUse->logicalWidth(), containerWidthInInlineDirection, cb);
         computedValues.m_extent = constrainLogicalWidthByMinMax(preferredWidth, containerWidthInInlineDirection, cb);
     }
 
     // Margin calculations.
-    computeMarginsForDirection(InlineDirection, cb, containerLogicalWidth, computedValues.m_extent, computedValues.m_margins.m_start,
-        computedValues.m_margins.m_end, style()->marginStart(), style()->marginEnd());
+    bool hasInvertedDirection = cb->style()->isLeftToRightDirection() == style()->isLeftToRightDirection();

[mstensho (USE GERRIT), 2014/12/04 12:18:29]

This name seems inverted. :) It's true when the direction is the same in both
renderers.

Also, we should have a test for LTR inside RTL.

But, more importantly: There are other calls to computeMarginsForDirection(),
and you haven't added any margin flipping there. Seems inconsistent. Maybe
computeMarginsForDirection() is the place to do this? That's where we make sure
to honor the align="right" thing anyway. So I think that doing it correctly
there would be the best fix.

[Kyungtae Kim, 2014/12/08 07:00:13]

Done.

+    computeMarginsForDirection(InlineDirection, cb, containerLogicalWidth, computedValues.m_extent,
+        hasInvertedDirection ? computedValues.m_margins.m_start :  computedValues.m_margins.m_end,

[mstensho (USE GERRIT), 2014/12/04 12:18:29]

extraneous space

[Kyungtae Kim, 2014/12/08 07:00:13]

Done.

+        hasInvertedDirection ? computedValues.m_margins.m_end : computedValues.m_margins.m_start,
+        style()->marginStart(), style()->marginEnd());
 
     if (!hasPerpendicularContainingBlock && containerLogicalWidth && containerLogicalWidth != (computedValues.m_extent + computedValues.m_margins.m_start + computedValues.m_margins.m_end)
         && !isFloating() && !isInline() && !cb->isFlexibleBoxIncludingDeprecated() && !cb->isRenderGrid()) {
         LayoutUnit newMargin = containerLogicalWidth - computedValues.m_extent - cb->marginStartForChild(*this);
         bool hasInvertedDirection = cb->style()->isLeftToRightDirection() != style()->isLeftToRightDirection();
         if (hasInvertedDirection)
             computedValues.m_margins.m_start = newMargin;
         else
             computedValues.m_margins.m_end = newMargin;
     }
@@ skipping 2528 matching lines @@
     computedValues.m_margins.m_end = marginEnd();
 
     setLogicalTop(oldLogicalTop);
     setLogicalWidth(oldLogicalWidth);
     setLogicalLeft(oldLogicalLeft);
     setMarginLeft(oldMarginLeft);
     setMarginRight(oldMarginRight);
 }
 
 } // namespace blink