Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 766103003: [Inspector] Deprecate usage of v8::Handle with v8::Local as replacement. (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
Reviewers:
haraken, vivekg, yurys
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Inspector] Deprecate usage of v8::Handle with v8::Local as replacement. This is minor refactoring done in order to encourage the usage of v8::Local in-lieu of v8::Handle within the inspector. BUG=424445 R=haraken@chromium.org R=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -69 lines) Patch
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 10 chunks +36 lines, -36 lines 0 comments Download
M Source/core/inspector/PromiseTracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/PromiseTracker.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/ScriptArguments.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M Source/core/inspector/ScriptDebugListener.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
PTAL. Bit of a trivial one, just getting started to tackle v8 bindings going forward ...
6 years ago (2014-12-09 12:03:20 UTC) #2
haraken
LGTM
6 years ago (2014-12-09 15:38:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766103003/1
6 years ago (2014-12-09 16:22:30 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-09 16:25:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186785

Powered by Google App Engine
This is Rietveld 408576698