Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: Source/core/inspector/PromiseTracker.cpp

Issue 766103003: [Inspector] Deprecate usage of v8::Handle with v8::Local as replacement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/PromiseTracker.h ('k') | Source/core/inspector/ScriptArguments.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PromiseTracker.cpp
diff --git a/Source/core/inspector/PromiseTracker.cpp b/Source/core/inspector/PromiseTracker.cpp
index 68dfcca3cf8ce0c653befc9893031df84a42c736..aa2a4ea9e816088039008eb721a34d3c9a5e2932 100644
--- a/Source/core/inspector/PromiseTracker.cpp
+++ b/Source/core/inspector/PromiseTracker.cpp
@@ -21,7 +21,7 @@ namespace blink {
class PromiseTracker::PromiseData final : public RefCountedWillBeGarbageCollectedFinalized<PromiseData> {
public:
- static PassRefPtrWillBeRawPtr<PromiseData> create(ScriptState* scriptState, int promiseHash, int promiseId, v8::Handle<v8::Object> promise)
+ static PassRefPtrWillBeRawPtr<PromiseData> create(ScriptState* scriptState, int promiseHash, int promiseId, v8::Local<v8::Object> promise)
{
return adoptRefWillBeNoop(new PromiseData(scriptState, promiseHash, promiseId, promise));
}
@@ -51,7 +51,7 @@ public:
private:
friend class PromiseTracker;
- PromiseData(ScriptState* scriptState, int promiseHash, int promiseId, v8::Handle<v8::Object> promise)
+ PromiseData(ScriptState* scriptState, int promiseHash, int promiseId, v8::Local<v8::Object> promise)
: m_scriptState(scriptState)
, m_promiseHash(promiseHash)
, m_promiseId(promiseId)
@@ -202,7 +202,7 @@ int PromiseTracker::circularSequentialId()
return m_circularSequentialId;
}
-PassRefPtrWillBeRawPtr<PromiseTracker::PromiseData> PromiseTracker::createPromiseDataIfNeeded(ScriptState* scriptState, v8::Handle<v8::Object> promise)
+PassRefPtrWillBeRawPtr<PromiseTracker::PromiseData> PromiseTracker::createPromiseDataIfNeeded(ScriptState* scriptState, v8::Local<v8::Object> promise)
{
int promiseHash = promise->GetIdentityHash();
RawPtr<PromiseDataVector> vector = nullptr;
@@ -235,13 +235,13 @@ PassRefPtrWillBeRawPtr<PromiseTracker::PromiseData> PromiseTracker::createPromis
return data.release();
}
-void PromiseTracker::didReceiveV8PromiseEvent(ScriptState* scriptState, v8::Handle<v8::Object> promise, v8::Handle<v8::Value> parentPromise, int status)
+void PromiseTracker::didReceiveV8PromiseEvent(ScriptState* scriptState, v8::Local<v8::Object> promise, v8::Local<v8::Value> parentPromise, int status)
{
ASSERT(isEnabled());
RefPtrWillBeRawPtr<PromiseData> data = createPromiseDataIfNeeded(scriptState, promise);
if (!parentPromise.IsEmpty() && parentPromise->IsObject()) {
- v8::Handle<v8::Object> handle = parentPromise->ToObject(scriptState->isolate());
+ v8::Local<v8::Object> handle = parentPromise->ToObject(scriptState->isolate());
RefPtrWillBeRawPtr<PromiseData> parentData = createPromiseDataIfNeeded(scriptState, handle);
data->m_parentPromiseId = parentData->m_promiseId;
data->m_parentPromise.set(scriptState->isolate(), handle);
« no previous file with comments | « Source/core/inspector/PromiseTracker.h ('k') | Source/core/inspector/ScriptArguments.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698