Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 7661023: Allow building libjpeg-turbo for ARM targets which lack support for the Neon (Closed)

Created:
9 years, 4 months ago by Sami
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Allow building libjpeg-turbo for ARM targets which lack support for the Neon instruction set. This change also removes the unnecessary dependency to yasm on ARM targets.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -19 lines) Patch
M libjpeg.gyp View 1 2 chunks +32 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Satish
http://codereview.chromium.org/7661023/diff/1/libjpeg.gyp File libjpeg.gyp (right): http://codereview.chromium.org/7661023/diff/1/libjpeg.gyp#newcode166 libjpeg.gyp:166: [ 'target_arch=="arm" and arm_neon==1', { can this be done ...
9 years, 4 months ago (2011-08-18 09:01:05 UTC) #1
Sami
Thanks for the review Satish. New patch set coming up. http://codereview.chromium.org/7661023/diff/1/libjpeg.gyp File libjpeg.gyp (right): http://codereview.chromium.org/7661023/diff/1/libjpeg.gyp#newcode166 ...
9 years, 4 months ago (2011-08-18 09:24:11 UTC) #2
Hironori Bono
LGTM. Thank you for your fix. I totally forgot ARM platforms that do not have ...
9 years, 4 months ago (2011-08-18 09:35:07 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-18 09:42:02 UTC) #4
Change committed as 97294

Powered by Google App Engine
This is Rietveld 408576698