Allow building libjpeg-turbo for ARM targets which lack support for the Neon

libjpeg.gyp

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'shared_generated_dir': '<(SHARED_INTERMEDIATE_DIR)/third_party/libjpeg_turbo',
     'conditions': [
       [ 'chromeos==1 or OS=="freebsd" or OS=="openbsd"', {
         # Link to system .so since we already use it due to GTK.
@@ skipping 144 matching lines @@
                 'simd/jdsamss2-64.asm',
                 'simd/jfss2fst-64.asm',
                 'simd/jfss2int-64.asm',
                 'simd/jfsseflt-64.asm',
                 'simd/jiss2flt-64.asm',
                 'simd/jiss2fst-64.asm',
                 'simd/jiss2int-64.asm',
                 'simd/jiss2red-64.asm',
               ],
             }],
-            [ 'target_arch=="arm"', {
+            # The ARM SIMD implementation requires the Neon instruction set.
+            [ 'target_arch=="arm" and arm_neon==1', {

[Satish, 2011/08/18 09:01:05]

can this be done with:
  [ 'target_arch=="arm"', {
    'conditions': [
      [ 'arm_neon==1', {
        'sources': [
          'simd/jsimd_arm.c',
          'simd/jsimd_arm_neon.S',
        ],
      }, {
        'sources': [
          'simd/jsimd_none.c',
        ],
      }]
    ],
  ],

[Sami, 2011/08/18 09:24:11]

Thanks, that is a lot more concise.

               'sources': [
                 'simd/jsimd_arm.c',
                 'simd/jsimd_arm_neon.S',
               ],
             }],
+            [ 'target_arch=="arm" and arm_neon==0', {
+              'sources': [
+                'jsimd_none.c',
+              ],
+            }],
 
             # Build rules for an asm file.
             # On Windows, we use the precompiled yasm binary. On Linux, we build
             # our patched yasm and use it except when use_system_yasm is 1. On
             # Mac, we always build our patched yasm and use it because of
             # <http://www.tortall.net/projects/yasm/ticket/236>.
             [ 'OS=="win"', {
               'variables': {
                 'yasm_path': '../yasm/binaries/win/yasm<(EXECUTABLE_SUFFIX)',
                 'yasm_format': '-fwin32',
@@ skipping 50 matching lines @@
                     ],
                   }],
                 ],
               },
             }],
           ],
           'rules': [
             {
               'rule_name': 'assemble',
               'extension': 'asm',
-              'inputs': [ '<(yasm_path)', ],
-              'outputs': [
-                '<(shared_generated_dir)/<(RULE_INPUT_ROOT).<(object_suffix)',
-              ],
-              'action': [
-                '<(yasm_path)',
-                '<(yasm_format)',
-                '<@(yasm_flags)',
-                '-DRGBX_FILLER_0XFF',
-                '-DSTRICT_MEMORY_ACCESS',
-                '-Isimd/',
-                '-o', '<(shared_generated_dir)/<(RULE_INPUT_ROOT).<(object_suffix)',
-                '<(RULE_INPUT_PATH)',
-              ],
-              'process_outputs_as_sources': 1,
-              'message': 'Building <(RULE_INPUT_ROOT).<(object_suffix)',
+              'conditions': [
+                [ 'target_arch!="arm"', {
+                  'inputs': [ '<(yasm_path)', ],
+                  'outputs': [
+                    '<(shared_generated_dir)/<(RULE_INPUT_ROOT).<(object_suffix)',
+                  ],
+                  'action': [
+                    '<(yasm_path)',
+                    '<(yasm_format)',
+                    '<@(yasm_flags)',
+                    '-DRGBX_FILLER_0XFF',
+                    '-DSTRICT_MEMORY_ACCESS',
+                    '-Isimd/',
+                    '-o', '<(shared_generated_dir)/<(RULE_INPUT_ROOT).<(object_suffix)',
+                    '<(RULE_INPUT_PATH)',
+                  ],
+                  'process_outputs_as_sources': 1,
+                  'message': 'Building <(RULE_INPUT_ROOT).<(object_suffix)',
+                }],
+              ]
             },
           ],
         },
       ],
     }, { # else: use_system_libjpeg != 0
       'targets': [
         {
           'target_name': 'libjpeg',
           'type': 'settings',
           'direct_dependent_settings': {
@@ skipping 10 matching lines @@
       ],
     }],
   ],
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: