chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix nat_policy.cc Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/pref_value_store.cc ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | chrome/test/webdriver/commands/command.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc b/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

index ad6b5d7940e1e14535b8bc96645f90d195d88ab9..71d4d613f36102ebf298975f3c1acc123df22d08 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc

@@ -34,7 +34,7 @@ void CloudPrintSetupMessageHandler::HandleSubmitAuth(const ListValue* args) {

}

scoped_ptr<Value> parsed_value(base::JSONReader::Read(json, false));

- if (!parsed_value.get() || !parsed_value->IsType(Value::TYPE_DICTIONARY)) {

+ if (!parsed_value.get() || !parsed_value->IsDictionary()) {

NOTREACHED() << "Unable to parse auth data";

return;

}

« no previous file with comments | « chrome/browser/prefs/pref_value_store.cc ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | chrome/test/webdriver/commands/command.cc » ('J')