Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/webdriver/commands/command.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nat_policy.cc Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/javascript_test_util.cc ('k') | chrome/test/webdriver/commands/set_timeout_commands_unittest.cc » ('j') | remoting/host/plugin/policy_hack/nat_policy_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/commands/command.cc
diff --git a/chrome/test/webdriver/commands/command.cc b/chrome/test/webdriver/commands/command.cc
index 95ad878f54fed029c992e52aaa1dbb8505a671bb..728c4dfb4c4aa4b136af5f9281e26ee246cd8a8f 100644
--- a/chrome/test/webdriver/commands/command.cc
+++ b/chrome/test/webdriver/commands/command.cc
@@ -41,7 +41,7 @@ bool Command::IsNullParameter(const std::string& key) const {
Value* value;
return parameters_.get() &&
parameters_->Get(key, &value) &&
- value->IsType(Value::TYPE_NULL);
+ value->IsNull();
tony 2011/08/19 17:24:21 Nit: Maybe we can fit this on 2 lines? Also, the
tfarina 2011/08/19 18:40:47 Done.
}
bool Command::GetStringParameter(const std::string& key,
« no previous file with comments | « chrome/test/ui/javascript_test_util.cc ('k') | chrome/test/webdriver/commands/set_timeout_commands_unittest.cc » ('j') | remoting/host/plugin/policy_hack/nat_policy_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698