chrome/test/webdriver/webdriver_element_id.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/webdriver_element_id.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/webdriver_element_id.cc

diff --git a/chrome/test/webdriver/webdriver_element_id.cc b/chrome/test/webdriver/webdriver_element_id.cc

index d618c07fd77c93e9b46c8ab8764c6c5df6a5f461..83badeac0ae4dcb0e132fadf9c951d1081d67397 100644

--- a/chrome/test/webdriver/webdriver_element_id.cc

+++ b/chrome/test/webdriver/webdriver_element_id.cc

@@ -33,7 +33,7 @@ ElementId::ElementId(const std::string& id) : id_(id), is_valid_(true) {}

ElementId::ElementId(const Value* value) {

is_valid_ = false;

- if (value->IsType(Value::TYPE_DICTIONARY)) {

+ if (value->IsDictionary()) {

is_valid_ = static_cast<const DictionaryValue*>(value)->

GetString(kWebElementKey, &id_);

}