Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: chrome/test/webdriver/webdriver_session.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/webdriver_element_id.cc ('k') | content/browser/debugger/devtools_netlog_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_session.cc
diff --git a/chrome/test/webdriver/webdriver_session.cc b/chrome/test/webdriver/webdriver_session.cc
index efd7b1ef6e6d651550b9e9430c5937a893250ee3..4f6a6972a0a832ace78a8e32b0349e7786539ebc 100644
--- a/chrome/test/webdriver/webdriver_session.cc
+++ b/chrome/test/webdriver/webdriver_session.cc
@@ -1137,7 +1137,7 @@ Error* Session::SwitchToFrameWithJavaScriptLocatedFrame(
virtual ~SwitchFrameValueParser() { }
virtual bool Parse(base::Value* value) const OVERRIDE {
- if (value->IsType(Value::TYPE_NULL)) {
+ if (value->IsNull()) {
*found_frame_ = false;
return true;
}
@@ -1218,7 +1218,7 @@ Error* Session::ExecuteFindElementScriptAndParse(
virtual ~FindElementsParser() { }
virtual bool Parse(base::Value* value) const OVERRIDE {
- if (!value->IsType(Value::TYPE_LIST))
+ if (!value->IsList())
return false;
ListValue* list = static_cast<ListValue*>(value);
for (size_t i = 0; i < list->GetSize(); ++i) {
@@ -1244,7 +1244,7 @@ Error* Session::ExecuteFindElementScriptAndParse(
virtual ~FindElementParser() { }
virtual bool Parse(base::Value* value) const OVERRIDE {
- if (value->IsType(Value::TYPE_NULL))
+ if (value->IsNull())
return true;
ElementId element;
bool set = SetFromValue(value, &element);
@@ -1292,7 +1292,7 @@ Error* Session::VerifyElementIsClickable(
virtual ~IsElementClickableParser() { }
virtual bool Parse(base::Value* value) const OVERRIDE {
- if (!value->IsType(Value::TYPE_DICTIONARY))
+ if (!value->IsDictionary())
return false;
DictionaryValue* dict = static_cast<DictionaryValue*>(value);
dict->GetString("message", message_);
« no previous file with comments | « chrome/test/webdriver/webdriver_element_id.cc ('k') | content/browser/debugger/devtools_netlog_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698