Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/test/webdriver/webdriver_dispatch.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/webdriver_dispatch.cc
diff --git a/chrome/test/webdriver/webdriver_dispatch.cc b/chrome/test/webdriver/webdriver_dispatch.cc
index 60d50f7b71a26d1698e0388be21873c9b786c18a..f7b1e98766b5ccc1ccbb1cb3b076bcdda1c87bcc 100644
--- a/chrome/test/webdriver/webdriver_dispatch.cc
+++ b/chrome/test/webdriver/webdriver_dispatch.cc
@@ -173,7 +173,7 @@ void PrepareHttpResponse(const Response& command_response,
case kMethodNotAllowed: {
const Value* const value = command_response.GetValue();
- if (!value->IsType(Value::TYPE_LIST)) {
+ if (!value->IsList()) {
// This should never happen.
http_response->set_status(HttpResponse::kInternalServerError);
http_response->SetBody(
@@ -266,7 +266,7 @@ bool ParseRequestInfo(const struct mg_request_info* const request_info,
"Failed to parse command data: " + error_msg + "\n Data: " + json));
return false;
}
- if (!params->IsType(Value::TYPE_DICTIONARY)) {
+ if (!params->IsDictionary()) {
response->SetError(new Error(
kBadRequest,
"Data passed in URL must be a dictionary. Data: " + json));
« no previous file with comments | « chrome/test/webdriver/webdriver_basic_types.cc ('k') | chrome/test/webdriver/webdriver_dispatch_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698