Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/test/webdriver/webdriver_basic_types.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/webelement_commands.cc ('k') | chrome/test/webdriver/webdriver_dispatch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_basic_types.cc
diff --git a/chrome/test/webdriver/webdriver_basic_types.cc b/chrome/test/webdriver/webdriver_basic_types.cc
index c72948c72f645256f6b2d4b5bf172831ff82596c..d5c9d387a29b028cbd191efc2233cb061efdcaf5 100644
--- a/chrome/test/webdriver/webdriver_basic_types.cc
+++ b/chrome/test/webdriver/webdriver_basic_types.cc
@@ -105,7 +105,7 @@ Value* ValueConversionTraits<webdriver::Point>::CreateValueFrom(
bool ValueConversionTraits<webdriver::Point>::SetFromValue(
const Value* value, webdriver::Point* t) {
- if (!value->IsType(Value::TYPE_DICTIONARY))
+ if (!value->IsDictionary())
return false;
const DictionaryValue* dict_value =
@@ -133,7 +133,7 @@ Value* ValueConversionTraits<webdriver::Size>::CreateValueFrom(
bool ValueConversionTraits<webdriver::Size>::SetFromValue(
const Value* value, webdriver::Size* t) {
- if (!value->IsType(Value::TYPE_DICTIONARY))
+ if (!value->IsDictionary())
return false;
const DictionaryValue* dict_value =
@@ -163,7 +163,7 @@ Value* ValueConversionTraits<webdriver::Rect>::CreateValueFrom(
bool ValueConversionTraits<webdriver::Rect>::SetFromValue(
const Value* value, webdriver::Rect* t) {
- if (!value->IsType(Value::TYPE_DICTIONARY))
+ if (!value->IsDictionary())
return false;
const DictionaryValue* dict_value =
« no previous file with comments | « chrome/test/webdriver/commands/webelement_commands.cc ('k') | chrome/test/webdriver/webdriver_dispatch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698