chrome/test/webdriver/commands/set_timeout_commands_unittest.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

diff --git a/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc b/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

index ff8f5ac25b8088c646cbeaa865b6b50b34554fa4..5d121778f2cf05cb9b454f4a1a3cf3d924368d74 100644

--- a/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

+++ b/chrome/test/webdriver/commands/set_timeout_commands_unittest.cc

@@ -31,7 +31,7 @@ void AssertError(ErrorCode expected_status,

ASSERT_EQ(expected_status, response.GetStatus()) << response.ToJSON();

const Value* value = response.GetValue();

- ASSERT_TRUE(value->IsType(Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(value->IsDictionary());

const DictionaryValue* dict = static_cast<const DictionaryValue*>(value);

std::string actual_message;