Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: chrome/common/web_apps.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/gaia/gaia_oauth_client.cc ('k') | chrome/common/web_resource/web_resource_unpacker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/web_apps.cc
diff --git a/chrome/common/web_apps.cc b/chrome/common/web_apps.cc
index b6591b7c71d82b1084f777f1c5b36733c40bd57d..198eadd70af4ce132934408919cc3364770f763a 100644
--- a/chrome/common/web_apps.cc
+++ b/chrome/common/web_apps.cc
@@ -222,8 +222,7 @@ bool ParseWebAppFromDefinitionFile(Value* definition_value,
&error_message));
CHECK(schema.get())
<< "Error parsing JSON schema: " << error_code << ": " << error_message;
- CHECK(schema->IsType(Value::TYPE_DICTIONARY))
- << "schema root must be dictionary.";
+ CHECK(schema->IsDictionary()) << "schema root must be dictionary.";
JSONSchemaValidator validator(static_cast<DictionaryValue*>(schema.get()));
@@ -239,7 +238,7 @@ bool ParseWebAppFromDefinitionFile(Value* definition_value,
// This must be true because the schema requires the root value to be a
// dictionary.
- CHECK(definition_value->IsType(Value::TYPE_DICTIONARY));
+ CHECK(definition_value->IsDictionary());
DictionaryValue* definition = static_cast<DictionaryValue*>(definition_value);
// Parse launch URL. It must be a valid URL in the same origin as the
« no previous file with comments | « chrome/common/net/gaia/gaia_oauth_client.cc ('k') | chrome/common/web_resource/web_resource_unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698