chrome/common/net/gaia/gaia_oauth_client.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/net/gaia/gaia_oauth_client.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/net/gaia/gaia_oauth_client.cc

diff --git a/chrome/common/net/gaia/gaia_oauth_client.cc b/chrome/common/net/gaia/gaia_oauth_client.cc

index dd82e1104aece994bad7d46d9ba4d9f6ce6c9e06..eff4dc6bbd629d5cc40c192d9cd07e3d3eb8e65b 100644

--- a/chrome/common/net/gaia/gaia_oauth_client.cc

+++ b/chrome/common/net/gaia/gaia_oauth_client.cc

@@ -158,8 +158,7 @@ void GaiaOAuthClient::Core::HandleResponse(

if (response_code == RC_REQUEST_OK) {

scoped_ptr<Value> message_value(

base::JSONReader::Read(data, false));

- if (message_value.get() &&

- message_value->IsType(Value::TYPE_DICTIONARY)) {

+ if (message_value.get() && message_value->IsDictionary()) {

scoped_ptr<DictionaryValue> response_dict(

static_cast<DictionaryValue*>(message_value.release()));

response_dict->GetString(kAccessTokenValue, &access_token);

« no previous file with comments | « chrome/common/json_value_serializer_unittest.cc ('k') | chrome/common/web_apps.cc » ('j') | no next file with comments »