chrome/browser/translate/translate_manager.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/translate/translate_manager.cc

diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc

index 66c91e862994a3cc7d6f8e7e4f04c1a6a51a7ee7..12bda9c81aacc638837f4374eddfd74289ac0764 100644

--- a/chrome/browser/translate/translate_manager.cc

+++ b/chrome/browser/translate/translate_manager.cc

@@ -184,7 +184,7 @@ void TranslateManager::SetSupportedLanguages(const std::string& language_list) {

// translate server so we must replace them with double quotes.

ReplaceSubstringsAfterOffset(&languages_json, 0, "'", "\"");

scoped_ptr<Value> json_value(base::JSONReader::Read(languages_json, true));

- if (json_value == NULL || !json_value->IsType(Value::TYPE_DICTIONARY)) {

+ if (json_value == NULL || !json_value->IsDictionary()) {

NOTREACHED();

return;

}