Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: chrome/browser/themes/browser_theme_pack_unittest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/syncable/model_type.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/browser_theme_pack_unittest.cc
diff --git a/chrome/browser/themes/browser_theme_pack_unittest.cc b/chrome/browser/themes/browser_theme_pack_unittest.cc
index 28bef94be1796810f15bca79a165386a706f01c4..7da8057579e8d6770adddfc9808b2334324cd563 100644
--- a/chrome/browser/themes/browser_theme_pack_unittest.cc
+++ b/chrome/browser/themes/browser_theme_pack_unittest.cc
@@ -78,7 +78,7 @@ class BrowserThemePackTest : public ::testing::Test {
void LoadColorJSON(const std::string& json) {
scoped_ptr<Value> value(base::JSONReader::Read(json, false));
- ASSERT_TRUE(value->IsType(Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsDictionary());
LoadColorDictionary(static_cast<DictionaryValue*>(value.get()));
}
@@ -88,7 +88,7 @@ class BrowserThemePackTest : public ::testing::Test {
void LoadTintJSON(const std::string& json) {
scoped_ptr<Value> value(base::JSONReader::Read(json, false));
- ASSERT_TRUE(value->IsType(Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsDictionary());
LoadTintDictionary(static_cast<DictionaryValue*>(value.get()));
}
@@ -98,7 +98,7 @@ class BrowserThemePackTest : public ::testing::Test {
void LoadDisplayPropertiesJSON(const std::string& json) {
scoped_ptr<Value> value(base::JSONReader::Read(json, false));
- ASSERT_TRUE(value->IsType(Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsDictionary());
LoadDisplayPropertiesDictionary(static_cast<DictionaryValue*>(value.get()));
}
@@ -109,7 +109,7 @@ class BrowserThemePackTest : public ::testing::Test {
void ParseImageNamesJSON(const std::string& json,
std::map<int, FilePath>* out_file_paths) {
scoped_ptr<Value> value(base::JSONReader::Read(json, false));
- ASSERT_TRUE(value->IsType(Value::TYPE_DICTIONARY));
+ ASSERT_TRUE(value->IsDictionary());
ParseImageNamesDictionary(static_cast<DictionaryValue*>(value.get()),
out_file_paths);
}
« no previous file with comments | « chrome/browser/sync/syncable/model_type.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698