chrome/browser/prefs/pref_value_store.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_value_store.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/pref_value_store.cc

diff --git a/chrome/browser/prefs/pref_value_store.cc b/chrome/browser/prefs/pref_value_store.cc

index bc759f84802476c5218c21cd14f52f9caffeb8ff..e023a045f2e1a0ecad1fb0c84e4a21fdb3a9512d 100644

--- a/chrome/browser/prefs/pref_value_store.cc

+++ b/chrome/browser/prefs/pref_value_store.cc

@@ -116,7 +116,7 @@ bool PrefValueStore::GetValue(const std::string& name,

for (size_t i = 0; i <= PREF_STORE_TYPE_MAX; ++i) {

if (GetValueFromStore(name.c_str(), static_cast<PrefStoreType>(i),

out_value)) {

- if (!(*out_value)->IsType(type)) {

+ if ((*out_value)->GetType() != type) {

LOG(WARNING) << "Expected type for " << name << " is " << type

<< " but got " << (*out_value)->GetType()

<< " in store " << i;