chrome/browser/prefs/pref_service_uitest.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_service_uitest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/pref_service_uitest.cc

diff --git a/chrome/browser/prefs/pref_service_uitest.cc b/chrome/browser/prefs/pref_service_uitest.cc

index ee9c2a46e51fe650ada83b8a82e2e211dccdc1db..4cc0d0ea4a51cf1195c50b449078a0b77860bc76 100644

--- a/chrome/browser/prefs/pref_service_uitest.cc

+++ b/chrome/browser/prefs/pref_service_uitest.cc

@@ -98,7 +98,7 @@ TEST_F(PreferenceServiceTest, PreservedWindowPlacementIsLoaded) {

scoped_ptr<Value> root(deserializer.Deserialize(NULL, NULL));

ASSERT_TRUE(root.get());

- ASSERT_TRUE(root->IsType(Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(root->IsDictionary());

DictionaryValue* root_dict = static_cast<DictionaryValue*>(root.get());

@@ -156,7 +156,7 @@ TEST_F(PreferenceServiceTest, PreservedWindowPlacementIsMigrated) {

scoped_ptr<Value> root(deserializer.Deserialize(NULL, NULL));

ASSERT_TRUE(root.get());

- ASSERT_TRUE(root->IsType(Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(root->IsDictionary());

// Retrieve the screen rect for the launched window

scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));

« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/pref_value_store.cc » ('j') | no next file with comments »