chrome/browser/extensions/extension_settings_api.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_settings_api.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_settings_api.cc

diff --git a/chrome/browser/extensions/extension_settings_api.cc b/chrome/browser/extensions/extension_settings_api.cc

index 411d3b38c0980a3369cede0b39810267b02dff07..d03308d170c19b57f1ab9f8aedf81c0a5152597b 100644

--- a/chrome/browser/extensions/extension_settings_api.cc

+++ b/chrome/browser/extensions/extension_settings_api.cc

@@ -59,7 +59,7 @@ bool GetSettingsFunction::RunWithStorageImpl(

std::string as_string;

ListValue* as_list;

- if (input->IsType(Value::TYPE_NULL)) {

+ if (input->IsNull()) {

storage->Get(new StorageResultCallback(this));

} else if (input->GetAsString(&as_string)) {

storage->Get(as_string, new StorageResultCallback(this));